Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an architectural problem we've seen with how to handle tags. I initially had an incomplete understanding of what a tag on Nostr is.
This change generalizes the
Tag
type to more closely match the Nostr spec. Each tag has a "name" and "value" and "other parameters", just like the README of the NIPs repo describes them. There will no longer be specific types for each name, because they cannot always be interpreted consistently outside the context of a specific event kind. We will still be able to have strongly typed and well-named properties at the event level.