Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tags #58

Merged
merged 1 commit into from
Aug 6, 2023
Merged

fix tags #58

merged 1 commit into from
Aug 6, 2023

Conversation

bryanmontz
Copy link
Collaborator

This PR fixes an architectural problem we've seen with how to handle tags. I initially had an incomplete understanding of what a tag on Nostr is.

This change generalizes the Tag type to more closely match the Nostr spec. Each tag has a "name" and "value" and "other parameters", just like the README of the NIPs repo describes them. There will no longer be specific types for each name, because they cannot always be interpreted consistently outside the context of a specific event kind. We will still be able to have strongly typed and well-named properties at the event level.

@bryanmontz bryanmontz merged commit f61b157 into main Aug 6, 2023
3 checks passed
@bryanmontz bryanmontz deleted the montz/tags branch August 6, 2023 18:21
RandyMcMillan pushed a commit to RandyMcMillan/nostr-sdk-ios that referenced this pull request Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants